Skip to content

Add missing error code for private method #43699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2017
Merged

Add missing error code for private method #43699

merged 1 commit into from
Aug 7, 2017

Conversation

@GuillaumeGomez
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm
Copy link
Member

kennytm commented Aug 6, 2017

Tidy failed, trailing whitespace and duplicated error code.

[00:04:02] tidy error: /checkout/src/test/compile-fail/E0623.rs:13: trailing whitespace
[00:04:03] tidy error: /checkout/src/librustc_typeck/diagnostics.rs:4655: trailing whitespace
[00:04:03] tidy error: /checkout/src/librustc_typeck/diagnostics.rs:4672: trailing whitespace
[00:04:03] tidy error: /checkout/src/librustc_typeck/diagnostics.rs:4676: trailing whitespace
[00:04:03] tidy error: /checkout/src/librustc_typeck/diagnostics.rs:4692: trailing whitespace
[00:04:03] tidy error: duplicate error code: 623
[00:04:03] tidy error: /checkout/src/librustc/diagnostics.rs:2028:     E0623, // lifetime mismatch where both parameters are anonymous regions
[00:04:03] tidy error: /checkout/src/librustc_typeck/diagnostics.rs:4647: E0623: r##"
[00:04:03] some tidy checks failed

@eddyb
Copy link
Member

eddyb commented Aug 6, 2017

r=me with fixed tidy

@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 6, 2017
Merged
@GuillaumeGomez
Copy link
Member Author

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Aug 6, 2017

📌 Commit 08188c3 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Aug 6, 2017

⌛ Testing commit 08188c3 with merge 2efdec34faa1d8789f0693392d60d045cb1e1beb...

@bors
Copy link
Collaborator

bors commented Aug 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 2efdec34faa1d8789f0693392d60d045cb1e1beb to master...

@bors
Copy link
Collaborator

bors commented Aug 6, 2017

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@kennytm
Copy link
Member

kennytm commented Aug 7, 2017

@bors retry #43535

@bors
Copy link
Collaborator

bors commented Aug 7, 2017

⌛ Testing commit 08188c3 with merge 70d962bff091ec76bdb557af632c1ab75aff02b5...

@bors
Copy link
Collaborator

bors commented Aug 7, 2017

⌛ Testing commit 08188c3 with merge 415c86b3fb4a08ffffe63fe99b0f6d64ed1b36b3...

@bors
Copy link
Collaborator

bors commented Aug 7, 2017

⌛ Testing commit 08188c3 with merge 3de807a...

bors added a commit that referenced this pull request Aug 7, 2017
@bors
Auto merge of #43699 - GuillaumeGomez:e0623, r=eddyb
3de807a 
Add missing error code for private method
@bors
Copy link
Collaborator

bors commented Aug 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 3de807a to master...

@bors bors merged commit 08188c3 into rust-lang:master Aug 7, 2017
@GuillaumeGomez GuillaumeGomez deleted the e0623 branch August 7, 2017 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddyb eddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @rust-highfive @kennytm @eddyb @bors